Tests/services for Common-API #272

Zapper9982 · 2025-08-04T23:42:42Z

📋 Description

This pull request introduces a significant number of new unit tests and fixes for existing tests across more than 80 files. The primary motivation is to enhance the overall test coverage of the Common-API service layer, improve code quality, and ensure the reliability of existing and new functionality. The changes address various failing tests and add comprehensive test cases for previously untested code paths.

NOTE :
Some of the extremely huge services which are Admin and CTI do not have a testcase cause of hallucinations will be looked into it with a later PR .

Some of the services have a RestTemplate instantiated within the method and not as a class declaration causing the methods to be rendered non - testable

@vanitha1822

✅ Type of Change

ℹ️ Additional Information

The changes were tested by running the full suite of unit tests locally. The focus has been on:

Adding new test cases to cover methods and classes that previously had low or no coverage.
Fixing existing tests that were failing due to issues like NullPointerException, incorrect mocking, or assertion errors.
Ensuring that all new and modified tests pass successfully.

The work spans over 80 files, indicating a widespread effort to improve the test harness of the application.

Screenshots

@drtechie @vanitha1822 Raising a PR , a total of 1705 Testcases are currently written.
Some of the failures are because of :

Assertion failures cause of different branches
some testcases failing cause of the inability to mock and test RestTemplate .

…bing

…some small tests

* fix: fixed the user session not found db issue * fix: fixed the redis config * fix: added the transit

coderabbitai · 2025-08-04T23:42:49Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Zapper9982 · 2025-08-05T19:21:33Z

56 tests run on CTIServiceImplTest successfully

Release 3.2.1 to main Branch merge

* Fix the issue in fetching the value for fields (PSMRI#257) * fix: Add jsonProperty to map with the request body to fix the issue in getting the value for income, education and occupation * fix: remove commented code * Update version in pom.xml to 3.4.0 * Update pom.xml * Add ServerAuthorization key in allow headers (PSMRI#275) * fix: add serverAuthorization * fix: add console * fix: correct the spelling * Nd/vs/token bengen issue (PSMRI#280) * fix: add useragent as java to skip the token * fix: add logger * fix: add logger --------- Co-authored-by: Vanitha S <116701245+vanitha1822@users.noreply.github.com> Co-authored-by: Amoghavarsh <93114621+5Amogh@users.noreply.github.com> Co-authored-by: Mithun James <drtechie@users.noreply.github.com>

vanitha1822 · 2025-09-01T08:51:26Z

src/main/java/com/iemr/common/service/everwell/EverwellRegistrationServiceImpl.java

 						if (everwellBenRegListAS != null) {

-							registerEverWellPatient(everwellBenRegListAS, Authorization);
+					   registerEverWellPatient(everwellBenRegListAS, Authorization, new RestTemplate());


Why is RestTemplate being passed here?

because , since the rest template is being created and used in the function its not testable ... so passing a rest template allows the code to be tested

another approach could also be that , the rest template could be defined at class level, but I wasnt sure that would be appropriate to do

@Zapper9982 Is it really necessary to add this extra parameter to the function? Have you tested whether it will not affect the flow of the application?

@vanitha1822 , yes as u can see I have changed all the calls to registereverwellPatient to have the rest template .

src/test/java/com/iemr/common/controller/carestream/CareStreamCreateOrderControllerTest.java

…/CareStreamCreateOrderControllerTest.java

…rom fork

sonarqubecloud · 2025-09-03T18:35:56Z

Quality Gate passed

Issues
693 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Zapper9982 and others added 21 commits July 5, 2025 23:49

feat(test): MockMvc tests cases for controllers - CommonAPI

b0684d4

Merge branch 'PSMRI:develop' into tests/controllers

4034a2c

fix(test): springcontext overloading fixed for mockmvc

ba1a1e9

fix(test): fixed according to codeRabbit suggestions

30423c7

Delete .vscode/settings.json

5c7230e

fix(test): fixed according to codeRabbit suggestions

95e0ecd

refactor(test):some redundant testfiles deleting

e8664a6

refactor(test):avoiding lenient stubbing and removing unecessary stub…

6e15991

…bing

misc(test): added GNU General Public license to all testfiles

d844d6a

fix(test): fixed according to codeRabbit suggestions

7251bf0

coverage(test) : increase coverage for feedback controller and added …

dcff787

…some small tests

fix(undo): undo controller change

9d96d04

fix(test): fixed according to codeRabbit suggestions

17e8555

feat(test):added new test methods completing the controllers and utils

e9b2853

the complete change for IEMR wasnt pushed pushing

3cfa664

fixing according to coderabbit and adding License

a7bbce5

fixing some minor test issues

57ddf11

fix: pom xml version change

a2997b0

fix: fixed the user session not found db issue (PSMRI#269)

87e6629

Production_ASSAM_Session timeout issue (PSMRI#270)

431ee92

* fix: fixed the user session not found db issue * fix: fixed the redis config * fix: added the transit

test(service) : Added unit tests for CommonAPI

c7e06f7

Zapper9982 added 2 commits August 6, 2025 00:39

test(service) : Added unit test for CTIServiceImplTest

82e4364

fix(test) : fixed CTIServiceImplTest

5692283

Zapper9982 and others added 4 commits August 8, 2025 02:18

license(add) : added GNU license to all test files

c21421d

remove(vscode) :settings.json

266bc3c

Merge pull request PSMRI#276 from PSMRI/release-3.2.1

43a5470

Release 3.2.1 to main Branch merge

vanitha1822 reviewed Sep 1, 2025

View reviewed changes

Zapper9982 and others added 4 commits September 1, 2025 16:43

fix(test): Delete src/test/java/com/iemr/common/controller/carestream…

934ee16

…/CareStreamCreateOrderControllerTest.java

Merge branch 'PSMRI:main' into tests/services-common

12ff5f8

test(workflow):workflow working

a33e2f8

test(workflow):making changes so that PR comment posted on PR's not f…

5489097

…rom fork

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tests/services for Common-API #272

Tests/services for Common-API #272

Uh oh!

Zapper9982 commented Aug 4, 2025

Uh oh!

coderabbitai bot commented Aug 4, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

Zapper9982 commented Aug 5, 2025

Uh oh!

vanitha1822 Sep 1, 2025

Uh oh!

Zapper9982 Sep 1, 2025

Uh oh!

Zapper9982 Sep 1, 2025

Uh oh!

vanitha1822 Sep 4, 2025

Uh oh!

Zapper9982 Sep 4, 2025

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 3, 2025

Uh oh!

Uh oh!

Tests/services for Common-API #272

Are you sure you want to change the base?

Tests/services for Common-API #272

Uh oh!

Conversation

Zapper9982 commented Aug 4, 2025

📋 Description

✅ Type of Change

ℹ️ Additional Information

Screenshots

Uh oh!

coderabbitai bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

Zapper9982 commented Aug 5, 2025

Uh oh!

vanitha1822 Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Zapper9982 Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Zapper9982 Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

vanitha1822 Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

Zapper9982 Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 3, 2025

Quality Gate passed

Uh oh!

Uh oh!

coderabbitai bot commented Aug 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)